Skip to content

Conversation

ayushworks
Copy link
Contributor

Use the new syntax of with in given as per #10538

Use the new syntax of `with` in given
@ShapelessCat
Copy link
Contributor

@ayushworks I think you need to sign https://www.lightbend.com/contribute/cla/scala first, and restart the checks.

By the way, I also notice a similar error in docs that you can fix. In file derivation.md, there is a missing with in the example code

  given Eq[Int] {
    def eqv(x: Int, y: Int) = x == y
  }

I guess if you sign the Scala CLA, add a commit to fix the code I mentioned, and the checks will restart automatically.

@OlivierBlanvillain
Copy link
Contributor

LGTM, thanks!

@OlivierBlanvillain OlivierBlanvillain merged commit 46290f9 into scala:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants